Skip to content
This repository has been archived by the owner on Feb 5, 2020. It is now read-only.

all: make tectonic license and pull secret optional #133

Closed
2 tasks
philips opened this issue Mar 25, 2017 · 3 comments
Closed
2 tasks

all: make tectonic license and pull secret optional #133

philips opened this issue Mar 25, 2017 · 3 comments
Assignees

Comments

@philips
Copy link
Contributor

philips commented Mar 25, 2017

The tectonic license and pull secret are required. If they aren't included we should simply not attempt to install the tectonic manifests. This will enable a few things:

  • bootkube can use this repo for cluster spin-up and testing
  • kubeadm could use this repo for testing across different environments
@philips
Copy link
Contributor Author

philips commented Mar 25, 2017

cc @luxas would you be interested in using this repo for kubeadm self-hosted testing? It would be a good way to start testing that across different repos. Essentially it would be creation of a module like https://github.com/coreos/tectonic-installer/tree/master/modules/bootkube

@klausenbusk
Copy link

So with this issue resolved, the installer can be used for setting up a non-tectonic cluster like coreos-kubernetes does?

@s-urbaniak
Copy link
Contributor

s-urbaniak commented Apr 20, 2017

@klausenbusk yes, setting tectonic_vanilla_k8s to true will deploy a vanilla k8s cluster only and works for AWS and Azure already today.

It is still a bit bumpy as you need to point to empty files for tectonic_license_path and tectonic_pull_secret_path as tectonic assets are being provisioned (but not deployed) but the basic functionality is there. I will file a follow-up PR which will not require pointing to empty license files/pull secrets (and probably also omitting rendering the tectonic assets at all).

@s-urbaniak s-urbaniak self-assigned this Apr 25, 2017
s-urbaniak added a commit to s-urbaniak/tectonic-installer that referenced this issue May 17, 2017
Currently both variables need to be set even if tectonic_vanilla_k8s is
set to true.

This fixes it.

Fixes coreos#133
s-urbaniak added a commit to s-urbaniak/tectonic-installer that referenced this issue May 17, 2017
Currently both variables need to be set even if tectonic_vanilla_k8s is
set to true.

This fixes it.

Fixes coreos#133
s-urbaniak pushed a commit that referenced this issue May 17, 2017
Currently both variables need to be set even if tectonic_vanilla_k8s is
set to true.

This fixes it.

Fixes #133
aknuds1 pushed a commit to aknuds1/tectonic-installer that referenced this issue May 19, 2017
Currently both variables need to be set even if tectonic_vanilla_k8s is
set to true.

This fixes it.

Fixes coreos#133
aknuds1 pushed a commit to aknuds1/tectonic-installer that referenced this issue May 19, 2017
Currently both variables need to be set even if tectonic_vanilla_k8s is
set to true.

This fixes it.

Fixes coreos#133
alekssaul pushed a commit to alekssaul/tectonic-installer that referenced this issue May 30, 2017
Currently both variables need to be set even if tectonic_vanilla_k8s is
set to true.

This fixes it.

Fixes coreos#133
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants