Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove negative look behind: clean repository #2372

Conversation

theseion
Copy link
Contributor

@theseion theseion commented Feb 5, 2022

Removed negative look-behind processing

Removed mention from data files

Removed look-behind conversion script

Removed processor from regexp-assemble.py

Updated readme

Relates to #2360

This is PR 4 of 4 that replace #2360.

@theseion theseion requested review from fgsch and fzipi February 5, 2022 09:16
@theseion theseion changed the title Remove negative look behind clean repository Remove negative look behind: clean repository Feb 5, 2022
@theseion theseion force-pushed the remove-negative-look-behind-clean-repository branch from 9f8c3c1 to 5d7020c Compare February 5, 2022 13:15
@theseion theseion force-pushed the remove-negative-look-behind-clean-repository branch from 5d7020c to 99cac98 Compare February 7, 2022 17:52
@theseion
Copy link
Contributor Author

theseion commented Feb 9, 2022

This is the last PR in the series @fzipi @fgsch. Please take a look.

@fzipi
Copy link
Member

fzipi commented Feb 9, 2022

@theseion You need to rebase this one also.

Removed mention from data files

Removed look-behind conversion script

Removed processor from regexp-assemble.py

Updated readme
@theseion theseion force-pushed the remove-negative-look-behind-clean-repository branch from 99cac98 to 94e6030 Compare February 9, 2022 16:43
@theseion
Copy link
Contributor Author

theseion commented Feb 9, 2022

You're right, thanks.

Copy link
Member

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🧹

@fzipi fzipi merged commit 95e89b5 into coreruleset:v3.4/dev Feb 9, 2022
@theseion theseion deleted the remove-negative-look-behind-clean-repository branch February 9, 2022 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants