feat: set "Host" header from dest_addr override #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- "Host" header should be overridden with value of `dest_addr` override to ensure that requests will be accepted by targets. - Added test for the above change. - Converted `config.FTWConfig.TestOverride.Input` from `map[string]string` to `test.Input` for improved validation and better parsing Co-authored-by: Dan Kegel <dkegel@fastly.com>
fzipi
approved these changes
Aug 18, 2022
anuraaga
pushed a commit
to anuraaga/go-ftw
that referenced
this pull request
Sep 1, 2022
…dr-override feat: set "Host" header from dest_addr override
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dest_addroverrideto ensure that requests will be accepted by targets.
config.FTWConfig.TestOverride.Inputfrommap[string]stringto
test.Inputfor improved validation and better parsingCo-authored-by: @dkegel-fastly
Replaces #61
Fixes #60