Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overriding dest_addr does not override Host header, leading to connection failures on some cloud WAFs #60

Closed
dkegel-fastly opened this issue Aug 7, 2022 · 1 comment · Fixed by #63
Closed

Overriding dest_addr does not override Host header, leading to connection failures on some cloud WAFs #60

dkegel-fastly opened this issue Aug 7, 2022 · 1 comment · Fixed by #63
Assignees
@theseion
Labels
enhancement New feature or request

Comments

@dkegel-fastly
Copy link
Contributor

This makes it hard to test WAFs running on hosting providers that rely on the Host header.

Overriding Host in applyInputOverride where it overrides DestAddr seems to fix this, draft PR coming.
@dkegel-fastly dkegel-fastly mentioned this issue Aug 7, 2022
Closed
@theseion theseion self-assigned this Aug 16, 2022
@theseion theseion added the enhancement New feature or request label Aug 16, 2022
@theseion
Copy link
Collaborator

Thanks @dkegel-fastly. I'm working on it.

@theseion theseion mentioned this issue Aug 18, 2022
Merged
@fzipi fzipi closed this as completed in #63 Aug 18, 2022
@theseion theseion mentioned this issue Feb 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theseion theseion

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: set "Host" header from dest_addr override theseion/go-ftw
2 participants
@theseion @dkegel-fastly