Add address parent check #1825
Merged
Add address parent check #1825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
src/CoreShop/Component/Core/Customer/CustomerTransformHelper.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Mario Ramundo <ramundomario@gmail.com>
|
PSALM tests failing because of this: Parent could be null, so PHPDoc should be: /**
* @return ElementInterface|null
*/WDYT @dpfaffenbauer? |
|
@ramundomario yes |
…m-fix Fix PSALM test for coreshop#1825
|
@ramundomario unfornuately the test still fails https://github.com/coreshop/CoreShop/runs/4656476471?check_suite_focus=true#step:14:42 |
|
@valentin- That is not your issue now. I will fix the tests and you have to rebase this PR after that. |
|
@valentin- can you rebase now pls? |
…op#1814 With this change submit order & submit quote urls are generated in `getResponse()` function of `SummaryCheckoutStep` instead of value of submit buttons
|
@dpfaffenbauer looks good now. |
dpfaffenbauer
approved these changes
Jan 5, 2022
|
thanks a lot @valentin- |
dpfaffenbauer
pushed a commit
to coreshop/Resource
that referenced
this pull request
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check if the parent exists. Tested in /de/shop/customer/addresses and also in the checkout process.