[CoreBundle] Fix fetch of checkout_finisher url from request
#1814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ramundomario I thought about adding the submit buttons to the form and take it from there. You have another idea? |
dpfaffenbauer
approved these changes
Dec 10, 2021
|
thanks btw :) |
I agree with you, but I would avoid putting the URL in a value of submit field, instead I would follow the example in symfony docs to generate the URL, depending on the button clicked, in |
|
@ramundomario definitely. We cannot change that for 2.x, but we can do it for 3.x. Would you create a PR? |
|
@dpfaffenbauer I'll try, maybe in the next week. |
ramundomario
added a commit
to ramundomario/CoreShop
that referenced
this pull request
Dec 22, 2021
…op#1814 With this change submit order & submit quote urls are generated in `getResponse()` function of `SummaryCheckoutStep` instead of value of submit buttons
valentin-
pushed a commit
to valentin-/CoreShop
that referenced
this pull request
Dec 29, 2021
…op#1814 With this change submit order & submit quote urls are generated in `getResponse()` function of `SummaryCheckoutStep` instead of value of submit buttons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup #1807 (comment)
It should fix the Behat UI failed test of #1812
Instead of taking the value from request we could get the value from the extra data of the form, let me know WDYT @dpfaffenbauer