Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve payment detail rendering #2207

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

solverat
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecation? no
Fixed tickets --

If your payment gateway provides nested details in given payments, the order/detail fetch will break (Warning: Array to string conversion)

This PR improves the detail grid view, if a detail value is not a simple array, it will be added as JSON encoded data to the grid (row body):

image

@dpfaffenbauer dpfaffenbauer added this to the 3.0.4 milestone Feb 10, 2023
@dpfaffenbauer dpfaffenbauer merged commit 9de5bf8 into coreshop:3.0 Feb 10, 2023
@dpfaffenbauer
Copy link
Member

nice, thanks @solverat

@solverat solverat deleted the payment_details_fix branch February 10, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants