Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing cascade merge #2636

Merged
merged 1 commit into from
May 23, 2024

Conversation

nehlsen
Copy link
Contributor

@nehlsen nehlsen commented May 23, 2024

fix missing cascade merge for conditions and actions of ProductSpecificPriceRule

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets #...

fix missing cascade persist for conditions and actions of ProductSpecificPriceRule
Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dpfaffenbauer
Copy link
Member

@nehlsen you mean the cascade-merge is missing? cascade-persist is there

@nehlsen nehlsen changed the title fix missing cascade persist fix missing cascade merge May 23, 2024
@nehlsen
Copy link
Contributor Author

nehlsen commented May 23, 2024

@dpfaffenbauer Yes! You are absolutely right! I have fixed the title and description.

@dpfaffenbauer dpfaffenbauer merged commit 133c71e into coreshop:4.0 May 23, 2024
277 checks passed
@dpfaffenbauer
Copy link
Member

@nehlsen thanks, I'll prepare a release tomorrow

@nehlsen
Copy link
Contributor Author

nehlsen commented May 23, 2024

Thanks! No release necessary for us. We are using bleeding edge 4.0 branch 😁

@solverat
Copy link
Contributor

solverat commented Jun 4, 2024

@dpfaffenbauer same in coreshop 3.2.x

benwalch added a commit to benwalch/CoreShop that referenced this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants