[WIP] refactor pimcore object data-tags to use DI for dependencies #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpfaffenbauer
force-pushed
the
pimcore-di-object-data-tags
branch
from
0db7c02
to
ce04dde
Compare
…reshop#3 fix tests for reused type
dpfaffenbauer
changed the title
|
this will not merged until this is resolved: pimcore/pimcore#4390 currently it is just to hot and could cause potential issues. |
|
will not come until pimcore properly supports this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes use of the Pimcore Implementation Loader to load Custom Object Data Tags. This reduces the usage of
Pimcore::getContainerand thus the risk of using private services.Since Pimcore doesn't really 100% support this, it is a bit tricky. We cannot store properties directly in the Data Class, since Pimcore uses
var_exportto store definition files, this also exports the dependencies and that will fail with the entity manager. So, we use a private static variable to handle that.