Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash while looking at ice&fire Recipe in JEI #2

Closed
BluMasc opened this issue Nov 5, 2020 · 5 comments
Closed

Crash while looking at ice&fire Recipe in JEI #2

BluMasc opened this issue Nov 5, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@BluMasc
Copy link

BluMasc commented Nov 5, 2020

The game crashes when trying to load some of the ice and fire mobs. I think they are doing something weird with rendering.

Maybe you could implement something that catches NullPointerExceptions and just renders nothing instead?

Pastebin: https://pastebin.pl/view/67262950

@Corgam
Copy link
Owner

Corgam commented Nov 5, 2020

Did you create your own json file for ice and fire entity?

@BluMasc
Copy link
Author

BluMasc commented Nov 5, 2020

Yes. Here is the file.
amphithere.txt

Changed to txt for upload purposes

@Corgam
Copy link
Owner

Corgam commented Nov 7, 2020

I looked into it. When NullPointerExceptions is catched, the RenderSystem already did some calculations. Even if we catch the exception it's really hard to revert already made changes and render no entity model. I will look into it again in the future, but for now IceAndFire won't be supported.

@Corgam Corgam added the enhancement New feature or request label Nov 7, 2020
@BluMasc
Copy link
Author

BluMasc commented Nov 9, 2020

OK, still thanks for your effort.

Additionally to anyone who looks at this. Most Ice and Fire mobs work, the ones who caused problems for me where these:

  • all Myrmex Kinds
  • the Sea Serpent
  • the Amphithere
  • the Siren

Also i didn't try the death worm or any of the dread creatures.

@Corgam
Copy link
Owner

Corgam commented Sep 15, 2021

I have added support for Fire and Ice, it will be up in the next update. All mobs are working except the Amphithere and I have no idea why, thus it is the only mob which will not be able to be sampled.

@Corgam Corgam closed this as completed Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants