Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] StackViewport not pulling metaData from provider list #671

Closed
kmcgurty opened this issue Jun 26, 2023 · 1 comment
Closed

[Bug] StackViewport not pulling metaData from provider list #671

kmcgurty opened this issue Jun 26, 2023 · 1 comment

Comments

@kmcgurty
Copy link

Describe the Bug

I believe this is the same bug as #669 but I thought I'd provide a little more information. After adding a provider (for eg. hardcodedMetaDataProvider), StackViewport.setStack never queries the list of metadata providers. If I put a console.log at this line of hardcodedMetaDataProvider.ts, it never appears.

Steps to Reproduce

It's easily viewable on the current WebLoader demo.

  1. https://www.cornerstonejs.org/live-examples/webloader
  2. View console, and notice that the image hasn't loaded
    image

The current behavior

  1. Initialize CornerstoneCore
  2. Add a meta data provider with CornerstoneCore.metaData.addProvider(HardcodedMetaDataProvider, 1)
  3. Register image loader, initialize renderingEngine and viewport
  4. Attempt to load an image with stackViewport.setStack(url)
  5. Step 4 fails to load the image, because the metadata is undefined

The expected behavior

The last version this works on is version 0.47.0 of the @cornerstonejs/core . If I downgrade to that version, it loads as expected. As soon as it's upgraded to 1.1.0 it breaks.

OS

Windows 10

Node version

20.3.1 (Current)

Browser

Chrome 114.0.5735.134

@sedghi
Copy link
Member

sedghi commented Jul 4, 2023

I can successfully run the webImageLoader and cannot reproduce this.

image

yarn run example webloader

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants