Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] ScaleOverlayTool is not displaying in viewport with different _FrameOfReferenceUID #673

Open
kubanm3 opened this issue Jun 28, 2023 · 0 comments

Comments

@kubanm3
Copy link
Contributor

kubanm3 commented Jun 28, 2023

Describe the Bug

Each series I put in viewport changes it's _FrameOfReferenceUID so that same annotations can be displayed in multiple viewports that share the same series.

With ScaleOverlayTool it remebers whether it got added to some viewport and after series is changed in that same viewport it doesn't add new scaleOverlay annotation, making it not render in that viewport.

Error is because of adding viewport to const viewportsWithAnnotations = []; in line 28 of ScaleOverlayTool.ts after changing series it doesn't add new annotation, because it thinks it already exists. But when rendering it gets annotations by FrameOfReferenceUID which doesnt exists.

Steps to Reproduce

  1. Create viewport with _FrameOfReferenceUID of seriesId.
  2. render that series in viewport
  3. enable ScaleOverlayTool so it gets added
  4. change series in viewport, also changing it's _FrameOfReferenceUID
  5. ScaleOverlayTool errors out and is not responsive

The current behavior

after changing frameofreference and rendering new series in viewport rendering ScaleOverlay tool errors in console and is not responsive.

The expected behavior

After series is changed and new _FrameOfReferenceUID is assigned to viewport ScaleOverlay annotation renders properly.

OS

Ubuntu 22.04.2 LTS

Node version

v20.1.0

Browser

Brave Version 1.52.122 Chromium: 114.0.5735.110 (Official Build) (64-bit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant