You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Each series I put in viewport changes it's _FrameOfReferenceUID so that same annotations can be displayed in multiple viewports that share the same series.
With ScaleOverlayTool it remebers whether it got added to some viewport and after series is changed in that same viewport it doesn't add new scaleOverlay annotation, making it not render in that viewport.
Error is because of adding viewport to const viewportsWithAnnotations = []; in line 28 of ScaleOverlayTool.ts after changing series it doesn't add new annotation, because it thinks it already exists. But when rendering it gets annotations by FrameOfReferenceUID which doesnt exists.
Steps to Reproduce
Create viewport with _FrameOfReferenceUID of seriesId.
render that series in viewport
enable ScaleOverlayTool so it gets added
change series in viewport, also changing it's _FrameOfReferenceUID
ScaleOverlayTool errors out and is not responsive
The current behavior
after changing frameofreference and rendering new series in viewport rendering ScaleOverlay tool errors in console and is not responsive.
The expected behavior
After series is changed and new _FrameOfReferenceUID is assigned to viewport ScaleOverlay annotation renders properly.
OS
Ubuntu 22.04.2 LTS
Node version
v20.1.0
Browser
Brave Version 1.52.122 Chromium: 114.0.5735.110 (Official Build) (64-bit)
The text was updated successfully, but these errors were encountered:
Describe the Bug
Each series I put in viewport changes it's _FrameOfReferenceUID so that same annotations can be displayed in multiple viewports that share the same series.
With ScaleOverlayTool it remebers whether it got added to some viewport and after series is changed in that same viewport it doesn't add new scaleOverlay annotation, making it not render in that viewport.
Error is because of adding viewport to
const viewportsWithAnnotations = [];
in line 28 of ScaleOverlayTool.ts after changing series it doesn't add new annotation, because it thinks it already exists. But when rendering it gets annotations by FrameOfReferenceUID which doesnt exists.Steps to Reproduce
The current behavior
after changing frameofreference and rendering new series in viewport rendering ScaleOverlay tool errors in console and is not responsive.
The expected behavior
After series is changed and new _FrameOfReferenceUID is assigned to viewport ScaleOverlay annotation renders properly.
OS
Ubuntu 22.04.2 LTS
Node version
v20.1.0
Browser
Brave Version 1.52.122 Chromium: 114.0.5735.110 (Official Build) (64-bit)
The text was updated successfully, but these errors were encountered: