Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set language to the chat message #131

Merged
merged 5 commits into from
May 26, 2023
Merged

fix: set language to the chat message #131

merged 5 commits into from
May 26, 2023

Conversation

aeswibon
Copy link
Member

@aeswibon aeswibon commented May 19, 2023 •
edited
Loading

Bug Fix

Proposed Changes

  • Migrates language field from Chat to ChatMessage
  • Adds language to converse endpoint

Associated Issue

Associated PR

@shivankacker
Copy link
Member

@cp-coder no need to call the translate APIs in the migration. We can just leave blanks, we don't have to have any backwards compatibility for now. Also can you rather than having message for the original message and translated_message for the translated message have message for the translated message and original_message for the english version?

@shivankacker shivankacker merged commit 6667d30 into ohcnetwork:master May 26, 2023
@Ashesh3 Ashesh3 mentioned this pull request May 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivankacker shivankacker shivankacker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set language to the chat message, not the chat object.
2 participants
@aeswibon @shivankacker