Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

self hosted model added #327

Merged
merged 3 commits into from
Sep 19, 2023
Merged

self hosted model added #327

merged 3 commits into from
Sep 19, 2023

Conversation

ishanExtreme
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Sep 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ayushma ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2023 4:14am

@Ashesh3
Copy link
Member

Ashesh3 commented Sep 17, 2023

Is the endpoint supposed to be open? No authentication needed?

@ishanExtreme
Copy link
Contributor Author

Is the endpoint supposed to be open? No authentication needed?

for now, care-whisper endpoint is open we can deploy it in Private Network so that only care microservices can use it, or if required we can add auth. Currently its not for public usage so we don't necessary required auth we can just deploy it in a Private Network.

@Ashesh3
Copy link
Member

Ashesh3 commented Sep 17, 2023

Is the endpoint supposed to be open? No authentication needed?

for now, care-whisper endpoint is open we can deploy it in Private Network so that only care microservices can use it, or if required we can add auth. Currently its not for public usage so we don't necessary required auth we can just deploy it in a Private Network.

The URL you added, whisper.ohc.network is not within a private network and is accessible and usable publicly. I am able to post URL of an audio and get it to transcribe. Just wanted to make sure if this was intentional and that by pushing that URL in this commit, the endpoint now being publicly known is okay.

@ishanExtreme
Copy link
Contributor Author

Is the endpoint supposed to be open? No authentication needed?

for now, care-whisper endpoint is open we can deploy it in Private Network so that only care microservices can use it, or if required we can add auth. Currently its not for public usage so we don't necessary required auth we can just deploy it in a Private Network.

The URL you added, whisper.ohc.network is not within a private network and is accessible and usable publicly. I am able to post URL of an audio and get it to transcribe. Just wanted to make sure if this was intentional and that by pushing that URL in this commit, the endpoint now being publicly known is okay.

Oh okay gotchya, fixing the issue...

@ishanExtreme
Copy link
Contributor Author

Fixed @Ashesh3

@shivankacker shivankacker merged commit f87d4e3 into master Sep 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants