Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing proper validation for phone number in patient registration form #1243

Closed
rithviknishad opened this issue Apr 7, 2023 · 4 comments
Closed

Missing proper validation for phone number in patient registration form #1243

rithviknishad opened this issue Apr 7, 2023 · 4 comments
Assignees
@sainak
Labels
good first issue Good for newcomers P2

Comments

@rithviknishad
Copy link
Member

rithviknishad commented Apr 7, 2023 •
edited
Loading

Describe the bug
When we register a patient and enter a number say with one digit missing, the patient is still getting created correctly. However, if one digit is missing for emergency phone number, it's validation works fine.

To Reproduce
Steps to reproduce the behavior:

  1. Create a patient
  2. Enter phone number with digits missing

Expected behavior
Phone Number also should be validated correctly, similar to Emergency Phone Number

Screenshots
image

image
@rithviknishad rithviknishad added good first issue Good for newcomers P2 labels Apr 7, 2023
Wesley26 referenced this issue in Wesley26/care_fe Apr 8, 2023
@Wesley26
issue-5281 Updated line 592 useEffect() hook to have the proper setMa…
2a7a149 
…xLength for a full US based number to be entered by end user
@NewtonFernandis
Copy link

I am working on this 👍

@NewtonFernandis
Copy link

Hey, @rithviknishad This is a backend issue. Could you please move it to the backend?

@NewtonFernandis NewtonFernandis removed their assignment Apr 8, 2023
@rithviknishad rithviknishad transferred this issue from coronasafe/care_fe Apr 9, 2023
@siddnikh siddnikh assigned siddnikh and unassigned siddnikh Apr 11, 2023
@sainak sainak self-assigned this May 19, 2023
sainak added a commit that referenced this issue May 23, 2023
@sainak
use consistent phone number validation
b0aac59 
Fixes #1243
@sainak sainak mentioned this issue May 23, 2023
Closed
3 tasks
@gitone912
Copy link

can i start working on this?

@rithviknishad
Copy link
Member Author

As you can see, it's already having a PR that fixes this issue.

sainak added a commit that referenced this issue Jun 6, 2023
@sainak
use consistent phone number validation
a7c6d8c 
Fixes #1243
sainak added a commit that referenced this issue Jun 7, 2023
@sainak
remove phone number field and use consistent phone number validation
e5568bf 
Fixes #1243
sainak added a commit that referenced this issue Jun 7, 2023
@sainak
remove phone number field and use consistent phone number validation
a47b857 
Fixes #1243
sainak added a commit that referenced this issue Jun 14, 2023
@sainak
remove phone number field and use consistent phone number validation
e7fb7cb 
Fixes #1243
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sainak sainak

Labels
good first issue Good for newcomers P2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use consistent phone number validation coronasafe/care
5 participants
@rithviknishad @sainak @siddnikh @gitone912 @NewtonFernandis