Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facility Filter for GET Users API #785

Closed
3 tasks
gigincg opened this issue May 25, 2022 · 4 comments
Closed
3 tasks

Facility Filter for GET Users API #785

gigincg opened this issue May 25, 2022 · 4 comments
Assignees

Comments

@gigincg
Copy link
Member

gigincg commented May 25, 2022

  • Add a facilities filter for GET Users API.
  • Create Issue in care_fe for building the filters in the UI
  • Create Issue in care_fe for creating link from Facility Home to /users?facility_id=xxxx
@mathew-alex mathew-alex added this to Care May 25, 2022
@mathew-alex mathew-alex moved this to Triage in Care May 25, 2022
@vigneshhari
Copy link
Member

vigneshhari commented May 25, 2022

We have another endpoint specifically for this already made. We can build this feature if that does not solve our problem.

@siddnikh siddnikh self-assigned this Jun 19, 2022
@gigincg
Copy link
Member Author

gigincg commented Jun 23, 2022

@vigneshhari Why are we using a different API for this? Isn't it against the standard pattern? Opinion on getting rid of the API and building the filter?

@siddnikh
Copy link
Contributor

@gigincg there's one for districts. I'm working on adding the facilities filter to the GET users API.

@gigincg gigincg moved this from Triage to In Progress in Care Jun 25, 2022
@vigneshhari
Copy link
Member

@gigincg we had a separate API for this because of the way we store this data internally. The facility user relation is a many-to-many type relation, we can bring in facility filters here but it would not be computationally inefficient. if there is a strong use case for this API, we can start thinking about implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants