Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send pretty details when password reset fails #1030

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Sep 19, 2022

Proposed Changes

  • This sends a pretty message to the frontend whenever a password reset attempt fails.
  • The frontend expects the detail field on 4xx error, instead of adding a special case for this, it's better to follow the standard and send a detail when the reset fails from the backend itself.

Associated Issue

@coronasafe/code-reviewers

image

image

@Ashesh3 Ashesh3 requested a review from a team as a code owner September 19, 2022 17:53
@codecov-commenter
Copy link

Codecov Report

Base: 55.94% // Head: 55.94% // No change to project coverage 👍

Coverage data is based on head (6aa99c9) compared to base (b717ef8).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1030   +/-   ##
=======================================
  Coverage   55.94%   55.94%           
=======================================
  Files         172      172           
  Lines        8574     8574           
  Branches     1479     1479           
=======================================
  Hits         4797     4797           
- Misses       3725     3728    +3     
+ Partials       52       49    -3     
Impacted Files Coverage Δ
care/users/reset_password_views.py 38.88% <0.00%> (ø)
care/users/management/commands/load_ward_data.py 0.00% <0.00%> (ø)
...are/facility/api/viewsets/patient_investigation.py 52.60% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vigneshhari vigneshhari merged commit b875eca into ohcnetwork:master Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Password Reset : Malfunctioning
3 participants