refactor discharge summary endpoints #1252
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #1252 +/- ##
==========================================
+ Coverage 56.18% 56.41% +0.23%
==========================================
Files 195 195
Lines 9625 9658 +33
Branches 1615 1615
==========================================
+ Hits 5408 5449 +41
+ Misses 4162 4154 -8
Partials 55 55
☔ View full report in Codecov by Sentry. |
|
required for coronasafe/care_fe#5246 |
sainak
force-pushed
the
feat/discharge-summary
branch
from
49ab4f8
to
20efcf8
Compare
| if summary.upload_completed: | ||
| return Response(FileUploadRetrieveSerializer(summary).data) | ||
|
|
||
| if summary.created_date <= timezone.now() - timedelta(minutes=2): |
There was a problem hiding this comment.
What edge case are we solving here?
| associating_id=consultation.external_id, | ||
| ).first() | ||
|
|
||
| if file_db_entry is None: |
There was a problem hiding this comment.
So the patient only has one discharge summary object?
| if ( | ||
| summary is not None | ||
| and not summary.upload_completed | ||
| and summary.created_date <= timezone.now() - timedelta(minutes=2) |
There was a problem hiding this comment.
should we maintain time restrictions in a system that is designed to be asynchronous?
| }, | ||
| ExpiresIn=2 * 24 * 60 * 60, # seconds | ||
| ) | ||
| return signed_url |
There was a problem hiding this comment.
Where is this function used ?
…ed count (#1286) Add validation for current bed count to be LESSER than total bed count in FacilityCapacitySerializer
|
@sainak what is the status on this PR |
added workflow for lambda docker build
updated branch filter
…nto feat/discharge-summary
|
SonarCloud Quality Gate failed.
|
|
@vigneshhari @sainak just a cautionary reminder/note: Upon merging #1247 the |
Proposed Changes
new summary fromat:
8b7a659a-d59e-4c8b-bb30-27f95b142ebb1681659555.pdf
@coronasafe/code-reviewers
Merge Checklist
/docs