Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add created_by_local_user_content field for patients notes #1445

Merged
merged 12 commits into from
Jul 21, 2023

Conversation

Bhavik-ag
Copy link
Contributor

@Bhavik-ag Bhavik-ag commented Jul 10, 2023

Proposed Changes

  • add a bool field created_by_local_user_content to check whether the creator of a patient note from the home facility

Before

image

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@siddnikh
Copy link
Contributor

siddnikh commented Jul 10, 2023

Remove the merge checklist from the PR description. Other than that, LGTM.

Copy link
Contributor

@siddnikh siddnikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format the code using precommit

@Bhavik-ag Bhavik-ag requested a review from siddnikh July 10, 2023 09:44
@GeekGawd
Copy link
Contributor

@Bhavik-ag there is already a serializer field that has validations built in you should use that instead of calling it directly. ExternalIdSerializerField

@Bhavik-ag
Copy link
Contributor Author

I hope this works now !!

@sainak
Copy link
Member

sainak commented Jul 17, 2023

@Bhavik-ag this serializer is being used at many places and adding the home_facility field will cause nested query calls everywhere, so it would be better to add a new field in PatientNotesSerializer called created_by_local_user which could be annotated on the queryset.

Copy link
Member

@sainak sainak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a field to PatientNotesSerializer instead of this serializer

@Bhavik-ag Bhavik-ag requested a review from sainak July 17, 2023 15:08
@Bhavik-ag
Copy link
Contributor Author

@sainak I have made the requested changes

@Bhavik-ag Bhavik-ag requested a review from sainak July 19, 2023 08:38
@sainak sainak changed the title Replace id with external_id for home_facility in UserBaseMinimumSerializer add created_by_local_user_content field for patients notes Jul 20, 2023
@vigneshhari vigneshhari merged commit 5275faf into coronasafe:master Jul 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants