-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add created_by_local_user_content field for patients notes #1445
Conversation
Remove the merge checklist from the PR description. Other than that, LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Format the code using precommit
@Bhavik-ag there is already a serializer field that has validations built in you should use that instead of calling it directly. |
I hope this works now !! |
@Bhavik-ag this serializer is being used at many places and adding the home_facility field will cause nested query calls everywhere, so it would be better to add a new field in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a field to PatientNotesSerializer instead of this serializer
@sainak I have made the requested changes |
Proposed Changes
created_by_local_user_content
to check whether the creator of a patient note from the home facilityBefore
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins