Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Doctor notes Realtime #6149

Closed
wants to merge 36 commits into from

Conversation

Bhavik-ag
Copy link
Contributor

@Bhavik-ag Bhavik-ag commented Aug 24, 2023

WHAT

🤖 Generated by Copilot at 5ce435a

This pull request adds a feature to view and add patient notes in a slide-over panel in the consultation details page, and refactors the patient notes components to use a common list and card component with infinite scrolling and WebSocket support. It also cleans up some code in various files by removing unused imports and improving formatting.

Proposed Changes

Backend Changes

Requirements to run locally

  • Should have webpush notifications working on the local setup

Screenshots / Videos

Care.Realtime.Doctor.Notes.webm

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

HOW

🤖 Generated by Copilot at 5ce435a

  • Add a slide-over panel for viewing and adding patient notes in the consultation details page (link, link, link, link, link, link, link)
  • Refactor the patient notes page to use the PatientNotesList component for rendering the notes list with infinite scrolling and pagination, and the Page component for rendering the page title and back button (link, link, link, link)
  • Add a new dependency react-infinite-scroll-component to the package.json file for implementing infinite scrolling in React components (link)
  • Format the l-minus and l-text icon paths in the UniconPaths.json file to fit in one line, and remove a trailing comma from the last icon path, for code style consistency and to avoid parsing errors (link, link, link)
  • Replace the Link component with the ButtonV2 component for rendering the "Doctor's Notes" button in the ConsultationDetails component, for UI consistency and functionality (link)
  • Add a semicolon at the end of the consultationBedVentilator variable declaration in the ConsultationDetails component, for code style consistency and to avoid potential errors (link)
  • Rearrange the order of the CSS classes applied to the span element that shows the number of assets associated with a bed in the Beds component, for code style consistency and readability (link)
  • Remove unused imports of the useSelector hook from various files, as they are not used in the corresponding components (link, link, link, link, link, link, link, link)
  • Remove an empty line from the Common.json file, for code style consistency and readability (link)
  • Add a newline at the end of the Consultation.json file, for code style consistency and readability (link)

@Bhavik-ag Bhavik-ag requested a review from a team August 24, 2023 11:17
@Bhavik-ag Bhavik-ag requested a review from a team as a code owner August 24, 2023 11:17
@vercel
Copy link

vercel bot commented Aug 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2023 2:56am

@netlify
Copy link

netlify bot commented Aug 24, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit f56edc1
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64f698c2b6e93500089367ae
😎 Deploy Preview https://deploy-preview-6149--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

👋 Hi, @Bhavik-ag,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@sainak
Copy link
Member

sainak commented Sep 20, 2023

@nihal467
Copy link
Member

already a combined single PR is raised #6224

@nihal467 nihal467 closed this Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge conflict pull requests with merge conflict needs testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make patient notes realtime
4 participants