Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add boundary based validation #1453

Closed
wants to merge 27 commits into from

Conversation

JahnabDutta
Copy link

@JahnabDutta JahnabDutta commented Jul 14, 2023

Proposed Changes

  • Change request body to /opearate_asset api to contain id of boundary-AssetBed realated to the given AssetBed and current CameraState.
  • Added validate_action in OnvifAsset to validate and kind of relativeMove, if the movement is within the range.
  • Changed handle_action in OnvifAsset to ensure additional parameters in the request body do not affect the handle_action function.
  • Created dummy validate_action in other asset integration modules for future use

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

Copy link
Member

@sainak sainak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert changes on non-relevant files

care/utils/assetintegration/onvif.py Show resolved Hide resolved
data/medibase.json Outdated Show resolved Hide resolved
requirements/base.txt Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (7273298) 60.43% compared to head (91e53d0) 60.75%.

Files Patch % Lines
care/utils/assetintegration/onvif.py 76.47% 2 Missing and 2 partials ⚠️
care/utils/assetintegration/base.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1453      +/-   ##
==========================================
+ Coverage   60.43%   60.75%   +0.32%     
==========================================
  Files         210      210              
  Lines       11473    11493      +20     
  Branches     1630     1634       +4     
==========================================
+ Hits         6934     6983      +49     
+ Misses       4307     4268      -39     
- Partials      232      242      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants