Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore admission date during discharge process if not provided #1475

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Jul 25, 2023

Proposed Changes

This pull request introduces a change that allows the discharge process to ignore the admission date if it's not provided. This avoids potential validation errors and exceptions during the discharge process when the admission date is absent.

  • Modified the validation logic in patient_consultation.py to check if the admission date exists before comparing it with the death date.

Fixes coronasafe/care_fe#5916

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@Ashesh3 Ashesh3 added the P1 High priority; urgent label Jul 25, 2023
@sainak
Copy link
Member

sainak commented Jul 26, 2023

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #1480

@Ashesh3
Copy link
Member Author

Ashesh3 commented Jul 27, 2023

See #1480

Fixed.

@gigincg gigincg merged commit 9f62e7a into master Jul 27, 2023
5 checks passed
@gigincg gigincg deleted the fix-discharge branch July 27, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High priority; urgent
Projects
None yet
4 participants