Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daily Rounds: Updated consciousness levels choices and migrated CANNOT BE ASSESSED to UNKNOWN #1670

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

aeswibon
Copy link
Member

@aeswibon aeswibon commented Oct 11, 2023

Proposed Changes

  • Updates Consciousness Levels Choices
  • Custom Migration: Migrate old option CANNOT_BE_ASSESSED to UNKNOWN

Updated Choices:

UNKNOWN (untouched)
ALERT (untouched)
RESPONDS_TO_VOICE (renamed)
RESPONDS_TO_PAIN (renamed)
UNRESPONSIVE (mapped to UNKNOWN)
AGITATED_OR_CONFUSED (new)
ONSET_OF_AGITATION_AND_CONFUSION (new)

Associated Issue

Before Migration (Map CANNOT BE ASSESSED - 25 to UNKNOWN - 0)

image

After Migration (Map CANNOT BE ASSESSED - 25 to UNKNOWN - 0)

image

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@aeswibon aeswibon added P1 High priority; urgent waiting-for-review labels Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7d2a033) 60.01% compared to head (0e3fdd0) 60.02%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1670   +/-   ##
=======================================
  Coverage   60.01%   60.02%           
=======================================
  Files         208      208           
  Lines       11318    11319    +1     
  Branches     1606     1606           
=======================================
+ Hits         6793     6794    +1     
  Misses       4301     4301           
  Partials      224      224           
Files Coverage Δ
care/facility/models/daily_round.py 86.17% <100.00%> (+0.06%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@nihal467
Copy link
Member

bug in the front-end, but functionality is partially ok

@rithviknishad rithviknishad changed the title fixed: updated consciousness levels Daily Rounds: Updated consciousness levels choices and migrated CANNOT BE ASSESSED to UNKNOWN Oct 18, 2023
@nihal467
Copy link
Member

LGTM @vigneshhari can you review it

@vigneshhari vigneshhari merged commit c96bb13 into coronasafe:master Oct 18, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High priority; urgent waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants