Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notifications for doctor notes #1688

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Add notifications for doctor notes #1688

merged 3 commits into from
Nov 21, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Oct 27, 2023

Continuation of #1553

Changes

  • Create webpush notification on note creation
  • Send patient_id and facility_id in the message
  • Add new notification type PATIENT_NOTE_ADDED
  • fixes make patient notes realtime  #1552

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (0daef7f) 60.02% compared to head (ab0420f) 60.10%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1688      +/-   ##
==========================================
+ Coverage   60.02%   60.10%   +0.07%     
==========================================
  Files         208      208              
  Lines       11319    11339      +20     
  Branches     1606     1610       +4     
==========================================
+ Hits         6794     6815      +21     
+ Misses       4301     4299       -2     
- Partials      224      225       +1     
Files Coverage Δ
care/facility/models/notification.py 100.00% <100.00%> (ø)
care/facility/api/viewsets/patient.py 63.23% <83.33%> (+0.90%) ⬆️
care/utils/notification_handler.py 51.93% <71.42%> (+1.27%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nihal467
Copy link
Member

LGTM

care/facility/api/viewsets/patient.py Show resolved Hide resolved
care/facility/api/viewsets/patient.py Outdated Show resolved Hide resolved
care/utils/notification_handler.py Show resolved Hide resolved
@Ashesh3 Ashesh3 requested a review from sainak November 3, 2023 08:56
@vigneshhari vigneshhari merged commit fefa1a9 into master Nov 21, 2023
8 checks passed
@vigneshhari vigneshhari deleted the doc-notes-notif branch November 21, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make patient notes realtime
5 participants