added webpush on notes creation #1553
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
sainak
approved these changes
Sep 6, 2023
|
PR looks good to me |
rithviknishad
approved these changes
Sep 11, 2023
vigneshhari
reviewed
Sep 11, 2023
| facility_users = FacilityUser.objects.filter(facility_id=patient.facility.id) | ||
| for facility_user in facility_users: | ||
| if facility_user.user.id != self.request.user.id: | ||
| send_webpush(username=facility_user.user, message=json.dumps(message)) |
There was a problem hiding this comment.
@sainak is this call deterministic, if not can we move it to the notification generator, it sends the webpush from the worker.
There was a problem hiding this comment.
Yes this is non-deterministic.
@Bhavik-ag can you move this to the notification generator?
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1553 +/- ##
==========================================
+ Coverage 59.11% 59.17% +0.05%
==========================================
Files 207 205 -2
Lines 11264 11162 -102
Branches 1599 1590 -9
==========================================
- Hits 6659 6605 -54
+ Misses 4405 4356 -49
- Partials 200 201 +1
☔ View full report in Codecov by Sentry. |
|
Closing stale MR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
patient_idandfacility_idin the messagePATIENT_NOTE_ADDED