Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate time from discharge_date #1734

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Truncate time from discharge_date #1734

merged 3 commits into from
Dec 1, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Nov 30, 2023

Proposed Changes

  • Truncate time from discharge_date as we never captured time so far from the user and contained dirty values.

Associated Issue

Notes:

We have ~10 records with invalid discharge dates (before admission_date) in staging.
image

Architecture changes

  • Remove this section if not used

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cae1743) 60.76% compared to head (98bb512) 60.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1734   +/-   ##
=======================================
  Coverage   60.76%   60.76%           
=======================================
  Files         210      210           
  Lines       11530    11530           
  Branches     1642     1642           
=======================================
  Hits         7006     7006           
  Misses       4283     4283           
  Partials      241      241           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nihal467
Copy link
Member

LGTM

@vigneshhari vigneshhari merged commit ae43cde into master Dec 1, 2023
11 checks passed
@vigneshhari vigneshhari deleted the clean-discharge-time branch December 1, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High priority; urgent waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants