Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for capturing time in Discharge Date #6757

Merged
merged 5 commits into from
Dec 1, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Nov 30, 2023

WHAT

🤖[deprecated] Generated by Copilot at c2ea000

Improved the user interface and functionality of the discharge modal component for facilities. Changed the discharge date input fields to datetime-local type and removed unnecessary code from DischargeModal.tsx.

Related (but not mandatorily required) backends:

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖[deprecated] Generated by Copilot at c2ea000

  • Replaced date pickers with text input fields for discharge date and time in DischargeModal.tsx (link, link)
  • Removed unused imports of DateFormField and FieldChangeEvent from DischargeModal.tsx (link)
  • Deleted commented out code that was assigning discharge value to patient data in DischargeModal.tsx (link)
  • Removed handleDateChange function that was updating pre-discharge form state with date value in DischargeModal.tsx (link)

@rithviknishad rithviknishad requested a review from a team as a code owner November 30, 2023 11:19
Copy link

netlify bot commented Nov 30, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 870b47e
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65689ac001930f00089b25de
😎 Deploy Preview https://deploy-preview-6757--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

vercel bot commented Nov 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2023 2:23pm

@rithviknishad rithviknishad added needs testing P1 breaking issue or vital feature waiting for backend labels Nov 30, 2023
Copy link

cypress bot commented Nov 30, 2023

Passing run #1650 ↗︎

0 88 0 0 Flakiness 0

Details:

Adds support for capturing time in Discharge Date
Project: CARE Commit: 870b47e96d
Status: Passed Duration: 02:23 💡
Started: Nov 30, 2023 2:26 PM Ended: Nov 30, 2023 2:28 PM

Review all test suite changes for PR #6757 ↗︎

conditional rendering for death-related fields
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 747e5f1 into develop Dec 1, 2023
58 of 60 checks passed
@khavinshankar khavinshankar deleted the discharge-datetime branch December 1, 2023 05:17
Copy link

github-actions bot commented Dec 1, 2023

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 breaking issue or vital feature tested
Projects
None yet
3 participants