Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nurse user type #1819

Merged
merged 10 commits into from
Jan 11, 2024
Merged

Add nurse user type #1819

merged 10 commits into from
Jan 11, 2024

Conversation

sainak
Copy link
Member

@sainak sainak commented Jan 10, 2024

This pull request adds a new user type called "Nurse" and migrates the existing staff users to the nurse role. It also includes updates to permissions checks.

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 73 lines in your changes are missing coverage. Please review.

Comparison is base (470ce0d) 61.05% compared to head (9aa2398) 61.23%.
Report is 1 commits behind head on master.

Files Patch % Lines
care/facility/api/viewsets/bed.py 8.33% 11 Missing ⚠️
care/facility/models/shifting.py 38.88% 11 Missing ⚠️
...are/facility/models/mixins/permissions/facility.py 35.71% 7 Missing and 2 partials ⚠️
care/facility/api/viewsets/file_upload.py 50.00% 6 Missing ⚠️
care/facility/api/viewsets/hospital_doctor.py 14.28% 6 Missing ⚠️
care/facility/models/patient_sample.py 25.00% 6 Missing ⚠️
care/facility/models/daily_round.py 50.00% 4 Missing and 1 partial ⚠️
care/facility/models/mixins/permissions/patient.py 28.57% 4 Missing and 1 partial ⚠️
care/facility/models/mixins/permissions/base.py 0.00% 2 Missing and 1 partial ⚠️
care/facility/models/resources.py 25.00% 3 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1819      +/-   ##
==========================================
+ Coverage   61.05%   61.23%   +0.18%     
==========================================
  Files         208      208              
  Lines       11529    11524       -5     
  Branches     1656     1647       -9     
==========================================
+ Hits         7039     7057      +18     
+ Misses       4218     4199      -19     
+ Partials      272      268       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nihal467
Copy link
Member

LGTM

sainak

This comment was marked as resolved.

Copy link
Member

@vigneshhari vigneshhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved without review.

@sainak sainak merged commit a92b60a into master Jan 11, 2024
10 of 11 checks passed
@sainak sainak deleted the sainak/feat/nurse-role branch January 11, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High priority; urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants