Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds user type: Nurse and Nurse (readonly) #6464

Merged
merged 9 commits into from
Jan 11, 2024
Merged

Adds user type: Nurse and Nurse (readonly) #6464

merged 9 commits into from
Jan 11, 2024

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Oct 18, 2023

WHAT

🤖 Generated by Copilot at ba07f48

Added Nurse role and updated user-related components and README. This pull request introduces a new user role Nurse and a read-only variant NurseReadOnly to the application. It also updates the user-related components and functions in src/Common/constants.tsx and src/Components/Users/UserAdd.tsx to use the new roles. Additionally, it changes the staffdev user role and the staff option in the video consultation component to Nurse in README.md and src/Components/Facility/DoctorVideoSlideover.tsx respectively.

Required Backends

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at ba07f48

  • Add Nurse and NurseReadOnly user roles to the application (link, link)
  • Change the staffdev user role from Staff to Nurse in the staging API credentials (link)
  • Enable doctors to assign video consultations to nurses instead of staff (link)
  • Refactor the UserAdd component to use a constant array for the user types that are related to a facility (link, link, link, link)
  • Remove the unused ROLE_STATUS_MAP object from the src/Common/constants.tsx file (link)

@rithviknishad rithviknishad requested a review from a team October 18, 2023 05:40
@rithviknishad rithviknishad requested a review from a team as a code owner October 18, 2023 05:40
@vercel
Copy link

vercel bot commented Oct 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 4:05pm

@netlify
Copy link

netlify bot commented Oct 18, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 3b448d2
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65a011b4ecc0360008ee8ab3
😎 Deploy Preview https://deploy-preview-6464--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress
Copy link

cypress bot commented Oct 18, 2023

Passing run #1864 ↗︎

0 98 0 0 Flakiness 0

Details:

Adds user type: Nurse and Nurse (readonly)
Project: CARE Commit: 3b448d2c2d
Status: Passed Duration: 02:11 💡
Started: Jan 11, 2024 4:08 PM Ended: Jan 11, 2024 4:11 PM

Review all test suite changes for PR #6464 ↗︎

@nihal467
Copy link
Member

LGTM

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Dec 6, 2023
Copy link

github-actions bot commented Dec 6, 2023

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@nihal467
Copy link
Member

@aeswibon clear the merge conflict

1 similar comment
@nihal467
Copy link
Member

nihal467 commented Jan 1, 2024

@aeswibon clear the merge conflict

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Jan 2, 2024
@nihal467
Copy link
Member

nihal467 commented Jan 2, 2024

@aeswibon

image
  • iam able to create a sample request using a staff id, can you reconfirm all the access control

@aeswibon
Copy link
Member

aeswibon commented Jan 2, 2024

@aeswibon

image * [ ] iam able to create a sample request using a staff id, can you reconfirm all the access control

Okay I will check

@aeswibon aeswibon self-assigned this Jan 2, 2024
@nihal467
Copy link
Member

LGTM , checked through tunnel provided by aakash

@khavinshankar khavinshankar merged commit e187977 into develop Jan 11, 2024
36 of 38 checks passed
@khavinshankar khavinshankar deleted the nurse branch January 11, 2024 16:33
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New user type "Nurse"
5 participants