Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core testing fixes #831

Merged
merged 49 commits into from
Jun 27, 2022
Merged

Core testing fixes #831

merged 49 commits into from
Jun 27, 2022

Conversation

skks1212
Copy link
Member

@skks1212 skks1212 commented Jun 7, 2022

In this PR

  • removed old broken tests
  • update docker-compose for tests
  • fixes pipelines
  • fixes audit_log middleware
  • add basic tests for users

#794

sainak and others added 30 commits June 7, 2022 03:03
update coverage-package and config
LGTM
* updated user tests, removed facility tests

Co-authored-by: Aakash Singh <46787056+sainAk@users.noreply.github.com>
* removed old tests

* work in progress

* Trying after removing report

* Trying to add step of coverage report

* Update setup.cfg

* Update setup.cfg

* Update setup.cfg

* final update to test workflow

* fixed mistake and testing pip caches

* it should solve

* updated cache settings and updated coveragerc
@gitguardian
Copy link

gitguardian bot commented Jun 26, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
196640 Generic Private Key 00d57de config/settings/base.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

2 similar comments
@gitguardian
Copy link

gitguardian bot commented Jun 26, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
196640 Generic Private Key 00d57de config/settings/base.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@gitguardian
Copy link

gitguardian bot commented Jun 26, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
196640 Generic Private Key 00d57de config/settings/base.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@sainak sainak marked this pull request as ready for review June 26, 2022 17:05
@sainak sainak requested a review from a team as a code owner June 26, 2022 17:05
@sainak sainak changed the title Testing Testing fixes Jun 26, 2022
@sainak sainak mentioned this pull request Jun 26, 2022
5 tasks
@sainak sainak changed the title Testing fixes Core testing fixes Jun 26, 2022
@vigneshhari
Copy link
Member

Approving without testing.

@vigneshhari vigneshhari merged commit b3b64ab into master Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants