Cleanup leftover admitted_to references #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeswibon
approved these changes
Jun 18, 2022
|
These changes needs to be vetted in detail since there might be a lot of broken references, This PR's review will be delayed. |
|
closes #911 |
|
merging with #924 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The attribute
admitted_towas removed from thePatientConsultationSerializer(here) but is still referred to in some parts. This change cleans up all the leftover code working withadmitted_to. It also removesADMIT_CHOICESwhich was exclusively used byadmitted_to.This change would be an addition to fix coronasafe/care_fe#2642 since the search filter there (Last Admitted to (Bed Type)) points to this deprecated and removed attribute.
Also some formatting issues by pre-commit-hooks
Frontend change: coronasafe/care_fe#2659
closes #911