-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove admitted_to filter #2659
Conversation
❌ Deploy Preview Failed. CC: @rithviknishad
|
@Ashesh3 I think we need to add this filter in the backend because @aparnacoronasafe opened an issue #2752 regarding this filter. |
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
757392 | Google API Key | 2cec8ae | src/Common/env.tsx | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
@Ashesh3 what is the PR status |
Backend change was merged, We can proceed to test out this PR. |
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Kudos, SonarCloud Quality Gate passed!
|
@Ashesh3 @gigincg is the admit_to filter getting removed or not, i can see @aparnacoronasafe comments been mentioned in it, can i get some clarity on this PR |
Dependent PR: coronasafe/care#924 |
👋 Hi, @Ashesh3, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
@Ashesh3 is the issue fixed, why was this pr closed? |
Yep, this was fixed by @sainak on the backend and as for the frontend, @aparnacoronasafe stated removing the admitted to isn't an option so this PR is not applicable. |
Closes #2642
Backend change: coronasafe/care#841
The attribute this filter is referring to is removed from the backend, hence applying this filter fails. This change will remove the filter from the UI and also clean it up from the backend.