Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove admitted_to filter #2659

Closed
wants to merge 2 commits into from
Closed

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Jun 8, 2022

Closes #2642
Backend change: coronasafe/care#841

The attribute this filter is referring to is removed from the backend, hence applying this filter fails. This change will remove the filter from the UI and also clean it up from the backend.

@Ashesh3 Ashesh3 requested a review from a team June 8, 2022 16:51
@Ashesh3 Ashesh3 requested a review from a team as a code owner June 8, 2022 16:51
@netlify
Copy link

netlify bot commented Jun 8, 2022

Deploy Preview Failed. CC: @rithviknishad

Name Link
🔨 Latest commit 71d4496
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/62a0d3ac2a37690009d5bcda

@aeswibon
Copy link
Member

@Ashesh3 I think we need to add this filter in the backend because @aparnacoronasafe opened an issue #2752 regarding this filter.

@gitguardian
Copy link

gitguardian bot commented Jun 27, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
757392 Google API Key 2cec8ae src/Common/env.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@nihal467
Copy link
Member

@Ashesh3 what is the PR status

@nihal467 nihal467 added the waiting for update PR is been dead for a long time label Jul 31, 2022
@Ashesh3
Copy link
Member Author

Ashesh3 commented Jul 31, 2022

@Ashesh3 what is the PR status

Backend change was merged, We can proceed to test out this PR.

@Ashesh3 Ashesh3 added needs testing and removed waiting for backend waiting for update PR is been dead for a long time labels Jul 31, 2022
@netlify
Copy link

netlify bot commented Jul 31, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit f89065a
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/62e613b617db330008d3cba3
😎 Deploy Preview https://deploy-preview-2659--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Jul 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.7% 0.7% Duplication

@nihal467
Copy link
Member

nihal467 commented Aug 3, 2022

@Ashesh3 @gigincg is the admit_to filter getting removed or not, i can see @aparnacoronasafe comments been mentioned in it, can i get some clarity on this PR

@nihal467 nihal467 added the question Further information is requested label Aug 3, 2022
@Ashesh3
Copy link
Member Author

Ashesh3 commented Aug 3, 2022

Dependent PR: coronasafe/care#924

@mathew-alex
Copy link
Contributor

👋 Hi, @Ashesh3,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@Ashesh3 Ashesh3 closed this Sep 28, 2022
@khavinshankar
Copy link
Member

@Ashesh3 is the issue fixed, why was this pr closed?

@Ashesh3
Copy link
Member Author

Ashesh3 commented Oct 6, 2022

@Ashesh3 is the issue fixed, why was this pr closed?

Yep, this was fixed by @sainak on the backend and as for the frontend, @aparnacoronasafe stated removing the admitted to isn't an option so this PR is not applicable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge conflict pull requests with merge conflict question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Patient list filter "Last Admitted" fails
5 participants