-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add fields for push score #987
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Codecov Report
@@ Coverage Diff @@
## master #987 +/- ##
==========================================
- Coverage 54.02% 52.61% -1.42%
==========================================
Files 182 182
Lines 8990 9036 +46
==========================================
- Hits 4857 4754 -103
- Misses 4133 4282 +149
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@@ -418,6 +439,15 @@ class InsulinIntakeFrequencyType(enum.Enum): | |||
default=list, validators=[JSONFieldSchemaValidator(NURSING_PROCEDURE)] | |||
) | |||
|
|||
length = models.FloatField(default=0.0, validators=[MinValueValidator(0)]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per ohcnetwork/care_fe#3432, each section must have these values, so we might have to dump these as a json. storing these as columns only allows us to store one instance of the value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aparnacoronasafe Discuss with @iamsdas to understand exactly what needs to be stored and how it needs to be represented. ( I might be wrong and this might be correct )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iamsdas @vigneshhari Yes, there will be multiple windows with these parameters, one for each pressure sore. Added clarification on the issue
Closing this PR, as will make a new one from the beginning. |
Proposed Changes
Add fields required for push score calculation in daily rounds:
fixes: #986
@coronasafe/code-reviewers