Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve how we consume icons in care #3850

Closed
1 of 3 tasks
rithviknishad opened this issue Oct 28, 2022 · 0 comments · Fixed by #4071
Closed
1 of 3 tasks

Improve how we consume icons in care #3850

rithviknishad opened this issue Oct 28, 2022 · 0 comments · Fixed by #4071
Assignees
@rithviknishad
Labels
wishlist

Comments

@rithviknishad
Copy link
Member

rithviknishad commented Oct 28, 2022 •
edited
Loading

As discussed in EOD and slack

  • Copy pf-icon implementation to care, so that icons that are not present in unicons can be added with the help of this.

Tasks to be accomplished eventually:

  • Replace material ui icons.
  • Replace fontawesome icons.

cc: @bodhish @skks1212 @gigincg
@rithviknishad rithviknishad self-assigned this Oct 28, 2022
@mathew-alex mathew-alex moved this to In Progress in Care Oct 28, 2022
@mathew-alex mathew-alex added this to Care Oct 28, 2022
@mathew-alex mathew-alex moved this from In Progress to Triage in Care Oct 28, 2022
@rithviknishad rithviknishad changed the title Copy pf-icon implementation and remove unicons Improve how we consume icons in care Oct 28, 2022
@rithviknishad rithviknishad mentioned this issue Nov 10, 2022
Merged
@rithviknishad rithviknishad mentioned this issue Nov 18, 2022
Merged
6 tasks
Repository owner moved this from Triage to Done in Care Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rithviknishad rithviknishad

Labels
wishlist
Projects
Care
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removes unicons support and introduces CareIcons library for internal use ohcnetwork/care_fe
1 participant
@rithviknishad