Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Purge asset.meta.middleware_address in favour of facility.middleware_address #4356

Closed
gigincg opened this issue Dec 19, 2022 · 1 comment · Fixed by #4357
Closed

Purge asset.meta.middleware_address in favour of facility.middleware_address #4356

gigincg opened this issue Dec 19, 2022 · 1 comment · Fixed by #4357
Assignees
@khavinshankar
Labels
P1 breaking issue or vital feature

Comments

@gigincg
Copy link
Member

gigincg commented Dec 19, 2022

As a follow up of #4122 We need to purge the asset.meta.middleware_address and replace all usages of it with facility.middleware_address
@gigincg gigincg added the P1 breaking issue or vital feature label Dec 19, 2022
@mathew-alex mathew-alex moved this to Triage in Care Dec 19, 2022
@mathew-alex mathew-alex added this to Care Dec 19, 2022
@github-actions
Copy link

⚠️ Refrain from assigning this issue to yourself if you have another P1 issue assigned that is not yet closed.

@khavinshankar khavinshankar self-assigned this Dec 19, 2022
@mathew-alex mathew-alex moved this from Triage to In Progress in Care Dec 19, 2022
@khavinshankar khavinshankar mentioned this issue Dec 19, 2022
Merged
6 tasks
Repository owner moved this from In Progress to Done in Care Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khavinshankar khavinshankar

Labels
P1 breaking issue or vital feature
Projects
Care
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use facility.middleware_address for asset.meta.middleware_hostname ohcnetwork/care_fe
2 participants
@gigincg @khavinshankar