Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Import/Export button to next line #5284

Closed
Pranshu1902 opened this issue Apr 8, 2023 · 4 comments · Fixed by #5290
Closed

Move Import/Export button to next line #5284

Pranshu1902 opened this issue Apr 8, 2023 · 4 comments · Fixed by #5290
Assignees
Labels
good first issue Good for newcomers

Comments

@Pranshu1902
Copy link
Contributor

Describe the bug
The Import/Export button is overlapping with the heading on External Results page

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://care.coronasafe.in/external_results
  2. See error

Expected behavior
The Import/Export button should be placed in next line just like it's on the Facility page
image

Screenshots
image

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@Pranshu1902 Pranshu1902 added the good first issue Good for newcomers label Apr 8, 2023
AbhishekPSingh07 added a commit to AbhishekPSingh07/care_fe that referenced this issue Apr 9, 2023
@AbhishekPSingh07
Copy link
Contributor

I Have added a PR for the same could you review it #5289

@rithviknishad
Copy link
Member

@AbhishekPSingh07 link pull requests to issues using keywords. Learn more here: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

@pamnanaimanish169
Copy link

Hi @rithviknishad, let me know if the issue is still open.

@rithviknishad
Copy link
Member

@pamnanaimanish169 this issue already has a PR (#5290) linked to it.
Feel free to checkout other good first issues here: https://github.com/coronasafe/care_fe/contribute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants