-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide the Delete Facility for user who don't have access to do it #6608
Comments
@nihal467 I want to work on this, can I know who don't have access to |
Can you assign this to me? |
@rithviknishad is this under the same category? Only state admin should see this button? |
@rithviknishad I wish to work on this issue can you assign it to me? |
@rithviknishad @nihal467 if i am not wrong a district admin must be able to delete the facility if the facility belongs to his district and the stateadmin must only be able to delete a facility if the facility is in his state right? |
Yes, but are you able to even read a facility that's outside of the district admin's district? If not, why bother defining that no-op check that'd always evaluate to true? |
@xakep8 unassigning as the related PR has not been followed up |
Describe the bug
Currently district admin and above have a delete facility button shown in the manage facility dropdown, even though they don't have permission to delete it
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Hide the delete facility button for users, who don't have permission to do it
Screenshots
The text was updated successfully, but these errors were encountered: