Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar link indicator is misplaced if font size is other than default one. #6879

Closed
Omkar76 opened this issue Dec 20, 2023 · 1 comment · Fixed by #6880
Closed

Sidebar link indicator is misplaced if font size is other than default one. #6879

Omkar76 opened this issue Dec 20, 2023 · 1 comment · Fixed by #6880
Assignees

Comments

@Omkar76
Copy link
Contributor

Omkar76 commented Dec 20, 2023

Describe the bug
Kinda similar to this bug #6805
The link indicator logic assumes that font size will always be 16px which is default for browsers. But this hardcoded height makes it look misplaced when user has changed default font size from browser settings.

To Reproduce

  • Go to browser settings and change default font size to anything other than 16px.
  • Go to care and notice the indicator. It's size doesn't change as per new font size.
  • Click on some links in sidebar you'll notice it's not positioned correctly before active link.

Expected behavior
Indicator size should change according to font size.
Indicator should be positioned accurately before active link.

Screenshots
font size is 24px. "Sample test" is active but indicator goes below "Resource"

image

@Omkar76
Copy link
Contributor Author

Omkar76 commented Dec 20, 2023

@rithviknishad, can you please assign this to me. I've tried a fix for this that seems to work well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant