Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend Adjustments for ABDM Plug Conversion #7817

Open
wants to merge 89 commits into
base: develop
Choose a base branch
from

Conversation

khavinshankar
Copy link
Member

@khavinshankar khavinshankar commented May 14, 2024

This pull request introduces necessary frontend changes to accommodate the backend conversion of ABDM into a plug. The specific changes include:

  • Fixes to Breaking Changes: Addressed and corrected several breaking changes that were introduced in the backend. These fixes ensure that the application maintains its functional integrity and provides a stable user experience without disruptions.

  • Enhanced Type Support: Improved the type definitions across the frontend codebase. This enhancement involves refining the use of TypeScript to ensure more robust and error-resistant code. It improves the predictability of code behavior through better compile-time checks and editor integrations.

  • Removal of Unwanted Console Logs: Cleaned up various console logs throughout the application that were no longer needed. This removal not only declutters the console output but also potentially improves performance by reducing unnecessary processing and output during runtime.

Depends on: coronasafe/care#2161

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label May 20, 2024
Copy link

netlify bot commented May 20, 2024

Deploy Preview for care-net failed.

Name Link
🔨 Latest commit 196007b
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/664af2f265311e0008799d88

@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label May 20, 2024
Copy link

👋 Hi, @khavinshankar,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label May 21, 2024
@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label May 23, 2024
@khavinshankar khavinshankar removed the Deploy-Failed Deplyment is not showing preview label May 23, 2024
@nihal467
Copy link
Member

@khavinshankar testing is kept on hold for this PR, due to the ABDM sandbox mobile app crashing. Once the service is back online, ping me, we will get it tested ASAP

@nihal467 nihal467 added the hold label Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants