Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend Adjustments for ABDM Plug Conversion #7817

Merged
merged 94 commits into from
Sep 17, 2024
Merged

Conversation

khavinshankar
Copy link
Member

@khavinshankar khavinshankar commented May 14, 2024

This pull request introduces necessary frontend changes to accommodate the backend conversion of ABDM into a plug. The specific changes include:

  • Fixes to Breaking Changes: Addressed and corrected several breaking changes that were introduced in the backend. These fixes ensure that the application maintains its functional integrity and provides a stable user experience without disruptions.

  • Enhanced Type Support: Improved the type definitions across the frontend codebase. This enhancement involves refining the use of TypeScript to ensure more robust and error-resistant code. It improves the predictability of code behavior through better compile-time checks and editor integrations.

  • Removal of Unwanted Console Logs: Cleaned up various console logs throughout the application that were no longer needed. This removal not only declutters the console output but also potentially improves performance by reducing unnecessary processing and output during runtime.

Depends on: ohcnetwork/care#2161

@nihal467
Copy link
Member

@khavinshankar testing is kept on hold for this PR, due to the ABDM sandbox mobile app crashing. Once the service is back online, ping me, we will get it tested ASAP

@nihal467 nihal467 added the hold label Jun 14, 2024
@nihal467
Copy link
Member

nihal467 commented Jul 2, 2024

@khavinshankar

image

the consent patient Abha ID is not verifying, and the push notifications are not being triggered in the applications, of chrome

netlify.toml Outdated Show resolved Hide resolved
@nihal467
Copy link
Member

nihal467 commented Jul 3, 2024

@khavinshankar
image

the consent api is failing, can you check it

@nihal467
Copy link
Member

nihal467 commented Jul 7, 2024

@khavinshankar can you fix the cypress failure

@nihal467
Copy link
Member

nihal467 commented Jul 8, 2024

LGTM

@khavinshankar
Copy link
Member Author

Closing this PR in favor of #8340

Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit e465b1e
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/66e8ddfcd1ce3c0008d8a326
😎 Deploy Preview https://deploy-preview-7817--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@khavinshankar khavinshankar merged commit 82a6700 into develop Sep 17, 2024
24 checks passed
@khavinshankar khavinshankar deleted the pre-abdm-plug branch September 17, 2024 01:55
Copy link

@khavinshankar Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants