Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced white spaces and added 2 column view Issue#2046 #2308

Closed
wants to merge 31 commits into from

Conversation

Pranshu1902
Copy link
Contributor

@Pranshu1902 Pranshu1902 commented May 10, 2022

Fixes #2046 Reduced white space on sides and made the form short

@Pranshu1902 Pranshu1902 requested a review from a team May 10, 2022 21:34
@developedBySJ
Copy link
Contributor

@Pranshu1902 Attach preview screenshot for PR.

@developedBySJ
Copy link
Contributor

A two-column layout is a better option.

image

What do you think @gigincg?

@arpancodes
Copy link
Contributor

@Pranshu1902 Also, please attach the PR to the respective issue.
Going forward you can use closing keywords while creating your PR itself.

@Pranshu1902
Copy link
Contributor Author

Pranshu1902 commented May 15, 2022

Screenshot of updated site 👇
Fixes #2046

image

@nihal467
Copy link
Member

@Pranshu1902 can you check the merging conflict!

@Pranshu1902 Pranshu1902 self-assigned this May 16, 2022
@Pranshu1902 Pranshu1902 changed the title Issue#2046 Reduced white spaces and added 2 column view Issue#2046 May 16, 2022
@nihal467
Copy link
Member

weodkewdp

@Pranshu1902 @gigincg the alignment is off and there is a merging conflict too

@Pranshu1902
Copy link
Contributor Author

@nihal467 a lot of the merging conflicts are because of the code I didn't even change.

.github/workflows/deploy.yaml Show resolved Hide resolved
src/Components/Facility/ConsultationForm.tsx Outdated Show resolved Hide resolved
@gigincg
Copy link
Member

gigincg commented May 31, 2022

@Pranshu1902 Update the labels when you've made changes, otherwise it won't get tested for QA

@Pranshu1902
Copy link
Contributor Author

@gigincg the issue has been resolved by @skks1212 in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Patient Consultation Form UI Change
6 participants