Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added spinner feedback after pressing login button #2341

Merged
merged 3 commits into from
May 17, 2022
Merged

Added spinner feedback after pressing login button #2341

merged 3 commits into from
May 17, 2022

Conversation

ishanExtreme
Copy link
Contributor

@ishanExtreme ishanExtreme commented May 13, 2022 •
edited
Loading

Issue Fixed

Fixes #2338

Updates

  • Button changed to submit type
  • onClick removed from button since it was already present in form's onSubmit
  • Spinner feedback is displayed by clicking log in button until a response is sent back by the server

Demo

Corona.Care.-.13.May.2022.mp4

@ishanExtreme ishanExtreme requested a review from a team May 13, 2022 16:40
developedBySJ
developedBySJ suggested changes May 16, 2022
View reviewed changes
src/Components/Auth/Login.tsx Outdated Show resolved Hide resolved
@nihal467
Copy link
Member

@ishanExtreme @gigincg there is a merging conflict !

@ishanExtreme
Copy link
Contributor Author

@ishanExtreme @gigincg there is a merging conflict !

Conflict fixed

@dauntlessnomad dauntlessnomad merged commit 532a22a into ohcnetwork:develop May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developedBySJ developedBySJ developedBySJ approved these changes

@dauntlessnomad dauntlessnomad dauntlessnomad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add feedback after user pressses the login button
4 participants
@ishanExtreme @nihal467 @dauntlessnomad @developedBySJ