Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the unhandled situation of QR code Scanner #2419

Merged
merged 9 commits into from
Jun 10, 2022

Conversation

patelaryan7751
Copy link
Contributor

Fixes #2359

Is this design okay if a user scans an invalid QR code he would be seeing this ? @gigincg
image

@patelaryan7751 patelaryan7751 added the question Further information is requested label May 18, 2022
@Parthan-Akon
Copy link

You can make the image a little bit smaller.
The size of the image seems too large compared to the screen size and other icons

@patelaryan7751
Copy link
Contributor Author

You can make the image a little bit smaller. The size of the image seems too large compared to the screen size and other icons
Is this okay ? @Parthan-Sachin
image

@netlify
Copy link

netlify bot commented May 19, 2022

👷 Deploy request for dreamy-fermat-b5024e pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 2ff435e

@patelaryan7751
Copy link
Contributor Author

Fixes #2359
Now the user will be given an error notification if he scans an invalid QR code
Screenshot from 2022-05-19 17-35-36

@patelaryan7751 patelaryan7751 marked this pull request as ready for review May 19, 2022 12:14
@patelaryan7751 patelaryan7751 requested a review from a team May 19, 2022 12:14
@patelaryan7751 patelaryan7751 added needs testing and removed question Further information is requested labels May 19, 2022
@nihal467
Copy link
Member

test approved

Copy link
Member

@khavinshankar khavinshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please work on the requested changes

navigate(`/assets/${assetId}`);
}
} catch (err) {
console.log(err);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do remove the console log if it is unintentional

Copy link
Contributor Author

@patelaryan7751 patelaryan7751 Jun 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khavinshankar the "err" variable is necessary as per syntax and inside the catch block if I don't use the "err" variable inside the catch block then I will be getting eslint errors and warnings.

src/Components/Assets/AssetsList.tsx Outdated Show resolved Hide resolved
@patelaryan7751 patelaryan7751 requested a review from a team as a code owner June 3, 2022 06:15
@patelaryan7751
Copy link
Contributor Author

Hey, @khavinshankar I have removed the unused commented lines instead of the console.log().

@khavinshankar khavinshankar merged commit 837c4d7 into ohcnetwork:develop Jun 10, 2022
@patelaryan7751 patelaryan7751 deleted the issue#2359 branch July 14, 2022 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhandled situation when we scan a QR code which doesnot conatin any AssetId .
4 participants