-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the unhandled situation of QR code Scanner #2419
Conversation
You can make the image a little bit smaller. |
👷 Deploy request for dreamy-fermat-b5024e pending review.Visit the deploys page to approve it
|
Fixes #2359 |
test approved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please work on the requested changes
navigate(`/assets/${assetId}`); | ||
} | ||
} catch (err) { | ||
console.log(err); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do remove the console log if it is unintentional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khavinshankar the "err" variable is necessary as per syntax and inside the catch block if I don't use the "err" variable inside the catch block then I will be getting eslint errors and warnings.
Hey, @khavinshankar I have removed the unused commented lines instead of the console.log(). |
Fixes #2359
Is this design okay if a user scans an invalid QR code he would be seeing this ? @gigincg