Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal for switching bed fixed #2473

Merged
merged 6 commits into from
Jun 10, 2022

Conversation

ishanExtreme
Copy link
Contributor

Issue Fixed

fixes #2458

Updates

  • Added small loader as original loader was making modal unresponsive
  • Shifted modal position
  • Made modal responsive

Demo

Consultation.Update._.Corona.Care.-.21.May.2022.mp4

@nihal467
Copy link
Member

eoifjw

@ishanExtreme @gigincg test failed,

  • the UI is very small
  • the date is not auto fetching
  • the date is not fully visible

@ishanExtreme
Copy link
Contributor Author

@nihal467
Can you give more details about date auto fetching issue.

@nihal467
Copy link
Member

@ishanExtreme @gigincg when we click the switch bed, button, the date of shifting column should be auto-filled with the current time and date

@ishanExtreme
Copy link
Contributor Author

@nihal467
Fixed above issues

@nihal467
Copy link
Member

epjof

@ishanExtreme @gigincg test failed, when we click the switch bed button, the current date and time are not been auto fetched

@ishanExtreme
Copy link
Contributor Author

@nihal467
After the new changes, I pushed 4 days a go, date of shift is now fetching current date
Screenshot from 2022-05-28 16-51-39

@ishanExtreme
Copy link
Contributor Author

@nihal467
Nelify preview build is not showing the latest changes

@rithviknishad
Copy link
Member

Netlify preview does show up with current date time for me.

image

@nihal467
Copy link
Member

test approved

Copy link
Member

@khavinshankar khavinshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do remove the comments and console logs

src/Components/Facility/Consultations/Beds.tsx Outdated Show resolved Hide resolved
src/Components/Facility/Consultations/Beds.tsx Outdated Show resolved Hide resolved
src/Components/TeleIcu/Patient/InfoCard.tsx Outdated Show resolved Hide resolved
@ishanExtreme ishanExtreme requested a review from a team as a code owner June 6, 2022 07:38
@khavinshankar khavinshankar merged commit a93c90d into ohcnetwork:develop Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch Bed Working Issue
4 participants