Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added appropriate message when no data is found #2474

Merged
merged 4 commits into from
Jun 23, 2022

Conversation

GokulramGHV
Copy link
Member

Fixes #2403

When no data is found, an appropriate message stating that no data is available is displayed.

image

image

image

@nihal467
Copy link
Member

@GokulramGHV @gigincg
poewkf

test failed, as there is no message showing in the medicine

@GokulramGHV
Copy link
Member Author

@nihal467 It is working for me...
Can you please share the link of the patricular page in which it is not working?

image

@GokulramGHV GokulramGHV added the question Further information is requested label May 27, 2022
@nihal467
Copy link
Member

@GokulramGHV GokulramGHV added needs testing and removed question Further information is requested test failed labels May 28, 2022
@nihal467
Copy link
Member

test approved

Copy link
Member

@khavinshankar khavinshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please work on following changes,

  • when an import is not used remove it instead of commenting it out
  • similarly for the unused variables, functions and interfaces, remove them instead of commenting it out
  • try to fix the eslint errors instead of using eslint disable (only when fixing the error is not possible go with eslint disable)

@GokulramGHV GokulramGHV requested a review from a team as a code owner June 15, 2022 03:47
@vercel
Copy link

vercel bot commented Jun 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-fe ❌ Failed (Inspect) Jun 15, 2022 at 3:53AM (UTC)

@khavinshankar khavinshankar merged commit 448e183 into ohcnetwork:develop Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display appropriate message when no data is found
3 participants