Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve toast notifications in mobile view #2476

Merged
merged 4 commits into from
May 25, 2022
Merged

Improve toast notifications in mobile view #2476

merged 4 commits into from
May 25, 2022

Conversation

naman114
Copy link
Contributor

fixes #2475
Centered the toast notification for mobile view and added swipe to dismiss

fix.toast.notif.v1.mp4

@naman114 naman114 requested a review from a team May 21, 2022 23:37
@nihal467
Copy link
Member

test approved

@gigincg
Copy link
Member

gigincg commented May 25, 2022

@naman114 Can you revert the package-lock, merge develop and do another npm install

@naman114
Copy link
Contributor Author

@gigincg I have resolved the merge conflict

@naman114 naman114 mentioned this pull request May 25, 2022
Closed
@gigincg gigincg merged commit 4c7a785 into ohcnetwork:develop May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

Assignees
No one assigned
Labels
changes required tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Toast notification misaligned in mobile view
4 participants
@naman114 @nihal467 @gigincg @khavinshankar