Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the review alert #2600

Merged
merged 5 commits into from
Jun 17, 2022
Merged

Fixed the review alert #2600

merged 5 commits into from
Jun 17, 2022

Conversation

khavinshankar
Copy link
Member

Fixes #2587

@khavinshankar
Copy link
Member Author

  • Hid review alert when the patient is discharged
  • Hid review alert when a daily round is created or when update is made after review time
  • In daily rounds form, added a hint to show the next expected review time
    image
    image
    image

Considerations:

  • Because we are storing absolute time in the backend and here in the frontend we are using relative time for review_time without any reference, it is not possible to set previous review time value in the form, so I went with the hint that notifies the user about the previous review time

@khavinshankar khavinshankar marked this pull request as ready for review June 1, 2022 12:53
@khavinshankar khavinshankar requested a review from a team June 1, 2022 12:53
@nihal467
Copy link
Member

nihal467 commented Jun 5, 2022

@khavinshankar @gigincg check the deploy failure

@nihal467 nihal467 added Deploy-Failed Deplyment is not showing preview and removed needs testing labels Jun 5, 2022
@khavinshankar khavinshankar requested a review from a team as a code owner June 6, 2022 11:06
@rithviknishad rithviknishad added needs testing and removed Deploy-Failed Deplyment is not showing preview labels Jun 9, 2022
@nihal467
Copy link
Member

test approved

@vercel
Copy link

vercel bot commented Jun 17, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-fe ✅ Ready (Inspect) Visit Preview Jun 17, 2022 at 4:58AM (UTC)

@gigincg gigincg merged commit 0db6a07 into develop Jun 17, 2022
@khavinshankar khavinshankar deleted the fix#2587 branch November 13, 2022 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review Alert : Broken
4 participants
@khavinshankar @nihal467 @gigincg @rithviknishad