Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UI on External Test page #2614

Merged
merged 6 commits into from
Jul 28, 2022
Merged

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Jun 1, 2022

Fixes #2505
Backend PR: ohcnetwork/care#810

Some UI changes to the External Test page.

Before:

image

After:

image

@Ashesh3 Ashesh3 requested a review from a team June 1, 2022 14:03
@Ashesh3 Ashesh3 changed the title Fix 2505 Improve UI on External Test page Jun 1, 2022
@gitguardian
Copy link

gitguardian bot commented Jun 27, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
757392 Google API Key 2cec8ae src/Common/env.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@nihal467
Copy link
Member

@Ashesh3 merge the latest deployment and check the conflicts

@Ashesh3 Ashesh3 requested a review from a team as a code owner July 11, 2022 07:36
@Ashesh3
Copy link
Member Author

Ashesh3 commented Jul 11, 2022

@nihal467 Done!

image

@nihal467
Copy link
Member

image

@Ashesh3 make it responsive

@netlify
Copy link

netlify bot commented Jul 19, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit db9914d
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/62dda765da3da2000adb2f7c
😎 Deploy Preview https://deploy-preview-2614--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Ashesh3
Copy link
Member Author

Ashesh3 commented Jul 19, 2022

@nihal467 Should be more responsive now:

300px width
image

@nihal467
Copy link
Member

@Ashesh3
image

check the responsivity

@Ashesh3
Copy link
Member Author

Ashesh3 commented Jul 24, 2022

Fixed.

@sonarcloud
Copy link

sonarcloud bot commented Jul 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 25 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@nihal467
Copy link
Member

test approved

@khavinshankar khavinshankar merged commit e69e164 into ohcnetwork:develop Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI issues on Upload External Results page
3 participants