Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#2807 - District filter for Users. #2808

Merged
merged 12 commits into from
Jul 27, 2022

Conversation

siddnikh
Copy link
Contributor

Solves #2807

@siddnikh siddnikh requested a review from a team June 23, 2022 12:00
@siddnikh siddnikh requested a review from a team as a code owner June 23, 2022 12:00
@siddnikh siddnikh added help wanted Extra attention is needed needs testing and removed help wanted Extra attention is needed labels Jun 23, 2022
@siddnikh siddnikh marked this pull request as draft June 23, 2022 12:06
@nihal467
Copy link
Member

@siddnikh once the work is completed, change the label to need testing

@siddnikh siddnikh marked this pull request as ready for review June 24, 2022 10:29
@nihal467
Copy link
Member

49

@siddnikh test failed, as it is not aligned to others

@gitguardian
Copy link

gitguardian bot commented Jun 27, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
757392 Google API Key 2cec8ae src/Common/env.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@nihal467
Copy link
Member

nihal467 commented Jul 3, 2022

@siddnikh

13

  • i have selected Ernakulam district and the badge is showing number 7
  • resolve the merging issue

@siddnikh
Copy link
Contributor Author

siddnikh commented Jul 3, 2022

@nihal467 Changes done as asked. Good for review!

@nihal467
Copy link
Member

test approved

@khavinshankar
Copy link
Member

image

@siddnikh the selected value is not showing

@netlify
Copy link

netlify bot commented Jul 23, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit dffef66
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/62dbb49bb61fab000946ac25
😎 Deploy Preview https://deploy-preview-2808--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Jul 23, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
7.2% 7.2% Duplication

@khavinshankar khavinshankar merged commit 731136d into ohcnetwork:develop Jul 27, 2022
khavinshankar added a commit that referenced this pull request Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants