Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Shifting letter Ui #2916

Merged
merged 4 commits into from
Jul 27, 2022

Conversation

patelaryan7751
Copy link
Contributor

Fixes #2857

Bugs Fixes

Improved Shifting letter Ui

image

Hey, @nihal467 is this okay?

@patelaryan7751 patelaryan7751 requested a review from a team June 27, 2022 06:00
@patelaryan7751 patelaryan7751 requested a review from a team as a code owner June 27, 2022 06:00
@patelaryan7751 patelaryan7751 added question Further information is requested needs testing labels Jun 27, 2022
@gitguardian
Copy link

gitguardian bot commented Jun 27, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
757392 Google API Key 2cec8ae src/Common/env.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@nihal467
Copy link
Member

11

@patelaryan7751 the right and left side margins of the page are not equal, make it well equal

@nihal467 nihal467 added work-in-progress and removed question Further information is requested needs testing labels Jun 29, 2022
@nihal467
Copy link
Member

@patelaryan7751 what is the status

@netlify
Copy link

netlify bot commented Jul 23, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 846ce9b
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/62dba694248e2700099e871d
😎 Deploy Preview https://deploy-preview-2916--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Jul 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@patelaryan7751
Copy link
Contributor Author

Hey @nihal467 is this okay?

shift

@nihal467
Copy link
Member

test approved

@khavinshankar khavinshankar merged commit 604c3a0 into ohcnetwork:develop Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revamp Referral Letter : Shifting
4 participants