Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added link from facility page to /facility/<external_id>/users/ #2956

Merged
merged 13 commits into from
Jul 13, 2022
Merged

Added link from facility page to /facility/<external_id>/users/ #2956

merged 13 commits into from
Jul 13, 2022

Conversation

siddnikh
Copy link
Contributor

@siddnikh siddnikh commented Jul 1, 2022

Solves #2955
Part of ohcnetwork/care#785

@siddnikh siddnikh requested a review from a team July 1, 2022 11:30
@siddnikh siddnikh requested a review from a team as a code owner July 1, 2022 11:30
@siddnikh siddnikh changed the title Added link from facility page to /users?facility=xxx Added link from facility page to /facility/<external_id>/users/ Jul 2, 2022
@siddnikh
Copy link
Contributor Author

siddnikh commented Jul 3, 2022

to see: Go to a facility home page and click on view users

naman114
naman114 reviewed Jul 5, 2022
View reviewed changes
Copy link
Contributor

@naman114 naman114 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The view users button directs to a 404 page @siddnikh

image

@nihal467
Copy link
Member

nihal467 commented Jul 6, 2022

@siddnikh update it to need testing once completed

@siddnikh siddnikh requested a review from naman114 July 6, 2022 18:56
naman114
naman114 approved these changes Jul 10, 2022
View reviewed changes
Copy link
Contributor

@naman114 naman114 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nihal467
Copy link
Member

test approved

@khavinshankar khavinshankar merged commit 2dad914 into ohcnetwork:develop Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naman114 naman114 naman114 approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

Assignees
No one assigned
Labels
peer-reviewed tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@siddnikh @nihal467 @khavinshankar @naman114